Introduce cron_shutdown function for stopping the main background worker #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally the main background worker ued to start tasks cannot be stopped, because it always auto restarts. This SQL function can be used to stop the background worker.
|
@microsoft-github-policy-service agree |
marcoslot
reviewed
Feb 28, 2025
| @@ -1 +1,7 @@ | |||
| /* no SQL changes in 1.6 */ | |||
| DROP FUNCTION IF EXISTS cron.shutdown(); | |||
| CREATE FUNCTION cron.shutdown() | |||
There was a problem hiding this comment.
this would require a new SQL script (1.7), otherwise existing 1.6 users will never get the function.
| LANGUAGE C STRICT | ||
| AS 'MODULE_PATHNAME', $$cron_shutdown$$; | ||
| COMMENT ON FUNCTION cron.shutdown() | ||
| IS 'shutdown pg_cron'; |
There was a problem hiding this comment.
should also revoke execute from public, to ensure only superuser can call this (or grant privileges)
|
|
||
| LWLockAcquire(scheduler_shared_data->lock, LW_EXCLUSIVE); | ||
| pid = scheduler_shared_data->scheduler_pid; | ||
| scheduler_shared_data->scheduler_pid = 0; |
There was a problem hiding this comment.
the code style should be adapted to the rest of the project
(except the Vixie cron logic in entry.c/misc.c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the main background worker used to start tasks cannot be stopped, because it always auto restarts.
This change introduces SQL function
cron_shutdownthat can be used to stop the background worker.It works by creating a shared memory that holds pid of the main background worker and bool flag specifying whether to restart the worker. By default, this keeps the current behaviour of automatically restarting the worker whenever it's killed. In situations when the user actually wants the main worker to be killed, It gives a way to do it.
This currently doesn't stop any other worker started by the scheduler.
The change that introduced auto-restarts is #286
Fixes #352